Feature Smile-SA#3184, phpcs cleaning and minor refactoring

romainruaud · Apr 18, 2024 · 93d2385 · 93d2385
1 parent d06b891
commit 93d2385
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/module-elasticsuite-catalog/Model/Category/Attribute/Source/SortDirection.php b/src/module-elasticsuite-catalog/Model/Category/Attribute/Source/SortDirection.php
@@ -37,13 +37,14 @@ public function getAllOptions()
                 ['label' => __('DESC'), 'value' => 'desc'],
             ];
         }
+
         return $this->_options;
     }
 
     /**
      * Get a text for option value.
      *
-     * @param string|int $value
+     * @param string|int $value Option value.
      *
      * @return string|bool
      */
@@ -54,6 +55,7 @@ public function getOptionText($value)
                 return $option['label'];
             }
         }
+
         return false;
     }
 }
diff --git a/src/module-elasticsuite-catalog/Plugin/Category/Toolbar/SortDirectionPerCategoryPlugin.php b/src/module-elasticsuite-catalog/Plugin/Category/Toolbar/SortDirectionPerCategoryPlugin.php
@@ -53,8 +53,8 @@ public function __construct(
     /**
      * Modify sorting direction before setting the collection in the toolbar.
      *
-     * @param ProductListToolbar $subject
-     * @param mixed $collection
+     * @param ProductListToolbar $subject    Product list toolbar.
+     * @param mixed              $collection Collection.
      *
      * @return array
      */

diff --git a/src/module-elasticsuite-catalog/Setup/CatalogSetup.php b/src/module-elasticsuite-catalog/Setup/CatalogSetup.php
@@ -15,7 +15,6 @@
 
 use Magento\Catalog\Api\Data\CategoryInterface;
 use Magento\Catalog\Model\Category;
-use Magento\Catalog\Model\ResourceModel\Eav\Attribute;
 use Magento\Eav\Model\Config;
 use Magento\Framework\EntityManager\MetadataPool;
 use Magento\Framework\Exception\LocalizedException;
@@ -926,11 +925,10 @@ private function updateCategoryAttributeDefaultValue($eavSetup, $entityTypeId, $
         $entitySelect = $connection->select();
         $entitySelect->from(
             $entityTable,
-            //[new \Zend_Db_Expr("{$attributeId} as attribute_id"), $linkField, new \Zend_Db_Expr("{$value} as value")]
             [
                 new \Zend_Db_Expr("{$attributeId} as attribute_id"),
                 $linkField,
-                new \Zend_Db_Expr((is_string($value) ? "'{$value}'" : $value) . ' as value')
+                new \Zend_Db_Expr((is_string($value) ? "'{$value}'" : $value) . ' as value'),
             ]
         );