Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

feat(): dedupe accepts a function #225

Merged
merged 2 commits into from
Jun 29, 2019

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Jun 16, 2019

Users can provide a function instead of an array to decide if a module is deduplicated or not.

src/index.js Outdated Show resolved Hide resolved
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, in order to merge this, we definitely need a test.

@manucorporat
Copy link
Contributor Author

Done! thanks for the feedback @lukastaegert !

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@lukastaegert lukastaegert merged commit df90657 into rollup:master Jun 29, 2019
@manucorporat manucorporat deleted the functional-dedup branch June 29, 2019 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants