fix(typescript): Ensure rollup 4 compatibility #1658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescript
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Existing v3 setup:
rollup@3
installed@rollup/plugin-typescript@11.1.0
installed which peer depends onrollup@3
@rollup/plugin-typescript@11.1.0
depends on@rollup/pluginutils@^5.0.1
@rollup/pluginutils@5.0.2
is resolved and saved in the lockfileTrying to upgrade to v4:
rollup@4
and@rollup/plugin-typescript@11.1.5
which peer depends onrollup@4
@rollup/plugin-typescript@11.1.5
still depends on@rollup/pluginutils@^5.0.1
@rollup/pluginutils@5.0.2
is not upgraded because it still matches@rollup/pluginutils@5.0.2
doesn't peer depend onrollup@4
This PR bumps the
pluginutils
dependency to^5.1.0
which is the earliest version that peer depends onrollup@4
.There are a bunch more errors like this throughout the whole repo, but I'm only fixing this one for now. It's unfortunate that it ended up this way and
pnpm install
happily passes. I opened pnpm/pnpm#6893 a while ago to report this behaviour.