chore(repo): central changes for Rollup 3 updates #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukastaegert
force-pushed
the
repo/rollup3-updates
branch
6 times, most recently
from
3691e17 to
8332f96
Compare
lukastaegert
force-pushed
the
repo/rollup3-updates
branch
from
8332f96 to
32aa6d2
Compare
This was referenced Sep 30, 2022
This was referenced Sep 30, 2022
This was referenced Sep 30, 2022
shellscape
reviewed
Oct 10, 2022
| @@ -1,4 +1,5 @@ | |||
| export default { | |||
| workerThreads: false, | |||
There was a problem hiding this comment.
@lukastaegert this change broke tests throughout the repo. symlinks that pointed to the old file are now broken. this didn't need to be changed either, as rollup doesn't use it directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
repoThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
This is a collection of changes I need to master first before merging all plugin update PRs I am currently preparing. This updates some central dependencies and ensures all packages build so that CI passes. It should be merged directly before the plugin updates are merged because not all packages may build directly after this update.
The most impactful change is probably the switch to Ava 4, which means that test files now need to follow proper Node semantics.