Skip to content

Commit

Permalink
refactor(commonjs): add early exit for namespace augmentation
Browse files Browse the repository at this point in the history
  • Loading branch information
lukastaegert committed Sep 18, 2020
1 parent cf662bd commit 6a91d84
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/commonjs/src/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export function getDefaultExportFromNamespaceIfNotNamed (n) {
}
export function getAugmentedNamespace(n) {
if (n.__esModule) return n;
var a = Object.defineProperty({}, '__esModule', {value: true});
Object.keys(n).forEach(function (k) {
var d = Object.getOwnPropertyDescriptor(n, k);
Expand Down
12 changes: 12 additions & 0 deletions packages/commonjs/test/snapshots/function.js.md
Original file line number Diff line number Diff line change
Expand Up @@ -2824,6 +2824,7 @@ Generated by [AVA](https://avajs.dev).
var externalEsmDefault = require('external-esm-default');␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -2869,6 +2870,7 @@ Generated by [AVA](https://avajs.dev).
var externalEsmDefault = require('external-esm-default');␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -2910,6 +2912,7 @@ Generated by [AVA](https://avajs.dev).
var externalEsmDefault = require('external-esm-default');␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -3049,6 +3052,7 @@ Generated by [AVA](https://avajs.dev).
});␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -3246,6 +3250,7 @@ Generated by [AVA](https://avajs.dev).
});␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -3351,6 +3356,7 @@ Generated by [AVA](https://avajs.dev).
var trueMixed = 'default';␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -3438,6 +3444,7 @@ Generated by [AVA](https://avajs.dev).
}␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -3643,6 +3650,7 @@ Generated by [AVA](https://avajs.dev).
});␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -3708,6 +3716,7 @@ Generated by [AVA](https://avajs.dev).
}␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -4262,6 +4271,7 @@ Generated by [AVA](https://avajs.dev).
});␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -4302,6 +4312,7 @@ Generated by [AVA](https://avajs.dev).
});␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down Expand Up @@ -4479,6 +4490,7 @@ Generated by [AVA](https://avajs.dev).
});␊
␊
function getAugmentedNamespace(n) {␊
if (n.__esModule) return n;␊
var a = Object.defineProperty({}, '__esModule', {value: true});␊
Object.keys(n).forEach(function (k) {␊
var d = Object.getOwnPropertyDescriptor(n, k);␊
Expand Down
Binary file modified packages/commonjs/test/snapshots/function.js.snap
Binary file not shown.
1 change: 1 addition & 0 deletions packages/commonjs/test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,7 @@ var esm = /*#__PURE__*/Object.freeze({
});
function getAugmentedNamespace(n) {
if (n.__esModule) return n;
var a = Object.defineProperty({}, '__esModule', {value: true});
Object.keys(n).forEach(function (k) {
var d = Object.getOwnPropertyDescriptor(n, k);
Expand Down

0 comments on commit 6a91d84

Please sign in to comment.