Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make DummyDA publicly available #13

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Oct 11, 2023

Overview

DummyDA is a simple, in-memory, minimalistic DA implementation for test purposes. It is used to validate unit tests in this repo, but should be public, so it can be used as "mock" by projects using go-da (for example to replace mock da in rollkit).

Resolves #6

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tzdybal tzdybal marked this pull request as ready for review October 11, 2023 13:36
tuxcanfly
tuxcanfly previously approved these changes Oct 11, 2023
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

da.go Outdated Show resolved Hide resolved
da.go Outdated Show resolved Hide resolved
Co-authored-by: Javed Khan <tuxcanfly@gmail.com>
@nashqueue nashqueue merged commit 6bd21b7 into main Oct 11, 2023
10 checks passed
@nashqueue nashqueue deleted the tzdybal/refactor_dummy branch October 11, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tests reusable
3 participants