build(deps:) update celestia-node to v0.13.2 #91
Conversation
|
Warning Rate Limit Exceeded@tuxcanfly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 33 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates involve increasing the required Go version to 1.22 and modifying the installation link for Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sum
Files selected for processing (4)
- .github/workflows/ci_release.yml (1 hunks)
- Dockerfile (1 hunks)
- README.md (2 hunks)
- celestia/celestia.go (2 hunks)
Additional comments: 7
.github/workflows/ci_release.yml (2)
- 29-29: Updating the Go version to "1.22" in the
lintjob is a good practice to keep the project up-to-date with the latest Go features and improvements. Ensure that all dependencies and actions used in this workflow are compatible with Go 1.22.- 34-34: Updating the Go version to "1.22" in the
testjob follows the same rationale as thelintjob. It's important to verify compatibility with all testing frameworks and dependencies used in this workflow.Dockerfile (1)
- 1-1: Updating the Golang version to 1.22 in the Dockerfile is consistent with the updates made in the CI workflow. This ensures that the development environment is up-to-date with the latest Go features and improvements. Make sure to verify that all tools and dependencies installed in the Dockerfile are compatible with Go 1.22.
README.md (2)
- 20-20: Updating the required Go version to 1.22 in the README.md is important for ensuring users set up their development environment with the correct version. This change aligns with the updates made in the CI workflow and Dockerfile.
- 81-81: Changing the installation link for
golangci-lintto a new URL is a helpful update for users. Please ensure that the new link is accessible and directs users to the correct installation instructions.celestia/celestia.go (2)
- 6-6: Importing
encoding/jsonis necessary for usingjson.Marshalin theGetProofsfunction. This change aligns with best practices for data serialization in Go.- 130-130: Replacing a custom marshaling function with
json.Marshalin theGetProofsfunction is a good practice for leveraging standard library functionalities. Ensure that the data structure being marshaled is fully compatible withjson.Marshaland that all necessary fields are correctly annotated for serialization.
tuxcanfly
force-pushed
the
tux/celestia-node-v0.13.2
branch
from
d4165ef
to
65c4668
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sum
Files selected for processing (4)
- .github/workflows/ci_release.yml (1 hunks)
- Dockerfile (1 hunks)
- README.md (2 hunks)
- celestia/celestia.go (2 hunks)
Files skipped from review as they are similar to previous changes (3)
- .github/workflows/ci_release.yml
- Dockerfile
- celestia/celestia.go
Additional comments: 5
README.md (5)
- 20-20: The update to specify Go version 1.22 or higher aligns with the PR's objective of ensuring environment compatibility with the new
celestia-nodeversion. This change is clear and correctly documented.- 81-81: The change in the installation link for
golangci-lintfromgolangci-lint.run/usage/install/togolangci-lint.run/welcome/install/is correctly updated to ensure users are directed to the appropriate installation guide. This aligns with the PR's emphasis on code refinements and maintaining up-to-date documentation.- 17-23: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The document's title "celestia-da" is correctly spelled, but the static analysis tool flagged it as a possible spelling mistake. This is a false positive, as "celestia-da" is the name of the project.
- 17-23: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [2-2]
The sentence starting with "celestia-da is an implementation of the Generic DA interface" does not start with an uppercase letter after the project name. This is a stylistic choice often used in README files where the project name is the first word of the sentence. It's acceptable in this context.
- 81-84: The static analysis tool flagged unpaired symbols (‘]’) in the list of tools. This is a false positive, as the markdown syntax for links is correctly used. Each tool installation link is properly formatted with both opening and closing square brackets.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 6
Configuration used: CodeRabbit UI
Files selected for processing (2)
- README.md (3 hunks)
- migration.md (1 hunks)
Additional comments: 2
README.md (2)
- 22-22: Updating the Go version requirement to 1.22 is a significant change. Verify that all CI/CD pipelines, Dockerfiles, and any build scripts have been updated accordingly.
- 83-86: The installation links for tools like
golangci-lint,markdownlint,hadolint, andyamllintare updated. Ensure that these links are accessible and that the installation instructions on these pages are up-to-date and correct.Verification successful
The provided URLs for
golangci-lint,markdownlint,hadolint, andyamllintin the README.md are accessible. This confirms that the installation links are correctly updated and accessible as per the review comment.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the provided URLs are accessible. urls=( "https://golangci-lint.run/welcome/install/" "https://github.com/DavidAnson/markdownlint" "https://github.com/hadolint/hadolint" "https://yamllint.readthedocs.io/en/stable/quickstart.html" ) for url in "${urls[@]}"; do if ! curl --output /dev/null --silent --head --fail "$url"; then echo "URL not accessible: $url" else echo "URL accessible: $url" fi doneLength of output: 1204
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- migration.md (1 hunks)
Additional comments: 1
migration.md (1)
- 26-26: The term "releasenotes" should be written as two separate words or hyphenated for clarity.
Overview
This PR updates celestia-node to v0.13.2. Also added a deprecation notice after the next release.
Checklist
Summary by CodeRabbit
celestia-daand migrating togo-daJSONRPC client.golangci-lint.GetProofsfunction for improved performance and compatibility.