Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

bump(deps): update celestia-node to v0.13.0 #76

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

tuxcanfly
Copy link
Collaborator

@tuxcanfly tuxcanfly commented Feb 12, 2024

Overview

This PR updates celestia-node to v0.13.0 and supports go-da v0.4.0.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features
    • Introduced a new parameter to enhance data handling and improve function calls, ensuring more precise operations.
  • Refactor
    • Streamlined code by removing unused imports and declarations.
    • Renamed and adjusted functions for better clarity and efficiency.
    • Modified method signatures to accommodate new parameters and improve usability.
  • Chores
    • Deprecated certain functionalities to align with updated operational standards.

Copy link

coderabbitai bot commented Feb 12, 2024

Warning

Rate Limit Exceeded

@tuxcanfly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 4 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 49591b2 and a648be6.

Walkthrough

The recent adjustments streamline the codebase by eliminating unnecessary components, refining function signatures, and integrating a new namespace parameter across various functions. This overhaul enhances the system's handling of namespaces and optimizes blob submission processes. Additionally, the deprecation of certain functionality signals a shift in focus towards more efficient data management techniques within the system.

Changes

Files Summary
celestia/celestia.go Removed unused imports/declarations, added ns parameter, updated logic, and renamed functions.
celestia/celestia_test.go Introduced ns variable, adjusted function calls to include ns parameter.

🐇✨
In the realm of code, where changes abound,
A rabbit hopped in, with leaps profound.
"Away with the old, in with the new,"
It declared, as through the files it flew.
With a flick and a hop, the namespace set,
Ensuring the data, in harmony, met.
🌟📜 "To efficiency and beyond!" it cheered,
As into the digital sunset it veered.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 5892064 and 509a5c1.
Files ignored due to path filters (2)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
Files selected for processing (4)
  • celestia/celestia.go (6 hunks)
  • celestia/celestia_test.go (3 hunks)
  • celestia/mock.go (1 hunks)
  • cmd/celestia-da/cmd.go (1 hunks)
Additional comments: 9
celestia/mock.go (1)
  • 20-20: The modification of the Submit method signature to include gasPrice float64 aligns with the focus on gas price considerations. Ensure that all tests and mock usages are updated to reflect this change.
celestia/celestia_test.go (2)
  • 32-34: Ensure that the nsHex variable is correctly decoded and used to derive the ns variable for namespace handling in tests.
  • 58-62: The re-declaration and usage of nsHex and ns in this test case follow the same pattern as earlier. Consistency in handling namespaces across tests is maintained.
celestia/celestia.go (6)
  • 53-56: The addition of the ns parameter in the Get function and its conditional assignment to c.namespace if nil is a good practice for backward compatibility and flexibility.
  • 70-72: The handling of the ns parameter in the GetIDs function is consistent with the changes made in the Get function, ensuring uniformity in namespace handling.
  • 86-89: The Commit function's adaptation to include the ns parameter and its conditional assignment demonstrates a consistent approach to integrating the new namespace handling across the codebase.
  • 95-98: The Submit function's modification to include the ns parameter and handle it similarly to other functions maintains the consistency and correctness of the namespace handling strategy.
  • 115-118: The GetProofs function's inclusion of the ns parameter and its handling align with the changes in other functions, ensuring a uniform approach to namespace management.
  • 155-158: The Validate function's integration of the ns parameter and its conditional handling are in line with the overall strategy for namespace management, ensuring consistency across the codebase.

cmd/celestia-da/cmd.go Show resolved Hide resolved
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (5892064) 74.05% compared to head (a648be6) 66.04%.

Files Patch % Lines
celestia/celestia.go 59.45% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   74.05%   66.04%   -8.01%     
==========================================
  Files           2        2              
  Lines         158      162       +4     
==========================================
- Hits          117      107      -10     
- Misses         28       43      +15     
+ Partials       13       12       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gupadhyaya gupadhyaya self-requested a review February 12, 2024 19:28
celestia/celestia.go Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 6

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 509a5c1 and 8c4a8c9.
Files selected for processing (2)
  • celestia/celestia.go (7 hunks)
  • celestia/celestia_test.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • celestia/celestia_test.go
Additional comments: 1
celestia/celestia.go (1)
  • 186-200: The functions makeID and splitID have been correctly renamed to MakeID and SplitID respectively, aligning with the PR objectives to improve readability and consistency. Ensure all references to these functions are updated accordingly.

celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
@gupadhyaya gupadhyaya self-requested a review February 12, 2024 20:34
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 6

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8c4a8c9 and 49591b2.
Files selected for processing (1)
  • celestia/celestia.go (6 hunks)

celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
celestia/celestia.go Outdated Show resolved Hide resolved
gupadhyaya
gupadhyaya previously approved these changes Feb 12, 2024
@gupadhyaya gupadhyaya merged commit 9fcf1f7 into main Feb 12, 2024
16 of 18 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants