-
Notifications
You must be signed in to change notification settings - Fork 14
bump(deps): update celestia-node to v0.13.0 #76
Conversation
Warning Rate Limit Exceeded@tuxcanfly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 4 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent adjustments streamline the codebase by eliminating unnecessary components, refining function signatures, and integrating a new namespace parameter across various functions. This overhaul enhances the system's handling of namespaces and optimizes blob submission processes. Additionally, the deprecation of certain functionality signals a shift in focus towards more efficient data management techniques within the system. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.mod
is excluded by:!**/*.mod
go.sum
is excluded by:!**/*.sum
Files selected for processing (4)
- celestia/celestia.go (6 hunks)
- celestia/celestia_test.go (3 hunks)
- celestia/mock.go (1 hunks)
- cmd/celestia-da/cmd.go (1 hunks)
Additional comments: 9
celestia/mock.go (1)
- 20-20: The modification of the
Submit
method signature to includegasPrice float64
aligns with the focus on gas price considerations. Ensure that all tests and mock usages are updated to reflect this change.celestia/celestia_test.go (2)
- 32-34: Ensure that the
nsHex
variable is correctly decoded and used to derive thens
variable for namespace handling in tests.- 58-62: The re-declaration and usage of
nsHex
andns
in this test case follow the same pattern as earlier. Consistency in handling namespaces across tests is maintained.celestia/celestia.go (6)
- 53-56: The addition of the
ns
parameter in theGet
function and its conditional assignment toc.namespace
ifnil
is a good practice for backward compatibility and flexibility.- 70-72: The handling of the
ns
parameter in theGetIDs
function is consistent with the changes made in theGet
function, ensuring uniformity in namespace handling.- 86-89: The
Commit
function's adaptation to include thens
parameter and its conditional assignment demonstrates a consistent approach to integrating the new namespace handling across the codebase.- 95-98: The
Submit
function's modification to include thens
parameter and handle it similarly to other functions maintains the consistency and correctness of the namespace handling strategy.- 115-118: The
GetProofs
function's inclusion of thens
parameter and its handling align with the changes in other functions, ensuring a uniform approach to namespace management.- 155-158: The
Validate
function's integration of thens
parameter and its conditional handling are in line with the overall strategy for namespace management, ensuring consistency across the codebase.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 74.05% 66.04% -8.01%
==========================================
Files 2 2
Lines 158 162 +4
==========================================
- Hits 117 107 -10
- Misses 28 43 +15
+ Partials 13 12 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 6
Configuration used: CodeRabbit UI
Files selected for processing (2)
- celestia/celestia.go (7 hunks)
- celestia/celestia_test.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- celestia/celestia_test.go
Additional comments: 1
celestia/celestia.go (1)
- 186-200: The functions
makeID
andsplitID
have been correctly renamed toMakeID
andSplitID
respectively, aligning with the PR objectives to improve readability and consistency. Ensure all references to these functions are updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
This PR updates celestia-node to v0.13.0 and supports go-da v0.4.0.
Checklist
Summary by CodeRabbit