cmd: add version command #51
Conversation
WalkthroughThe project has evolved to manage its versioning independently from Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (3)
- Makefile (1 hunks)
- cmd/celestia-da/main.go (1 hunks)
- cmd/celestia-da/version.go (1 hunks)
Additional comments: 5
cmd/celestia-da/main.go (1)
- 34-34: The addition of
versionCmdtorootCmdis correctly implemented and follows the established pattern for adding new commands.Makefile (1)
- 13-13: The update to the build message in the
Makefileis correct and reflects the new build process forcelestia-da.cmd/celestia-da/version.go (3)
46-51: The
buildInfostruct is well-defined and matches the expected fields populated by the Makefile's ldflags.53-92: The
extractBuildInfofunction parses the ldflags string correctly. However, the keys used in the switch statement (e.g.,.buildTime) should match the actual keys set in the Makefile's ldflags. Verify that the keys are consistent.95-117: The
versionCmdcommand andprintBuildInfofunction are correctly implemented. Ensure that the output format of the version information is consistent with the project's standards.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 73.02% 73.02%
=======================================
Files 2 2
Lines 152 152
=======================================
Hits 111 111
Misses 28 28
Partials 13 13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- go.mod
Files selected for processing (1)
- cmd/celestia-da/version.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- cmd/celestia-da/version.go
tuxcanfly
force-pushed
the
tux/cmd-version
branch
from
2c7b128
to
aea3dd8
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- go.mod
Files selected for processing (3)
- Makefile (2 hunks)
- cmd/celestia-da/main.go (1 hunks)
- cmd/celestia-da/version.go (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- Makefile
- cmd/celestia-da/main.go
- cmd/celestia-da/version.go
tuxcanfly
force-pushed
the
tux/cmd-version
branch
from
aea3dd8
to
59fc6c7
Compare
go mod tidy cmd: version command cleanup
tuxcanfly
force-pushed
the
tux/cmd-version
branch
from
59fc6c7
to
789f83c
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- Makefile (2 hunks)
- cmd/celestia-da/main.go (1 hunks)
- cmd/celestia-da/version.go (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- Makefile
- cmd/celestia-da/main.go
- cmd/celestia-da/version.go
Overview
This PR adds a version command Fixes #48
Checklist
Summary by CodeRabbit
New Features
celestia-da.Enhancements