Skip to content

Commit

Permalink
refactor: 499 - review suggestions implemented
Browse files Browse the repository at this point in the history
  • Loading branch information
Wystov committed Sep 13, 2024
1 parent 7e5bb35 commit 82a1976
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 10 deletions.
11 changes: 3 additions & 8 deletions src/widgets/alumni/ui/alumni.module.scss
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
.info-wrapper {
h2,
p {
width: 640px;
margin-top: 0;

@include media-tablet {
width: 100%;
}
}

p {
margin-top: 16px;
}
}

.alumni {
Expand All @@ -19,8 +15,7 @@
row-gap: 48px;
place-items: center;

margin-top: 40px;
margin-bottom: 48px;
padding: 40px 0 48px;
}

.logo-container {
Expand Down Expand Up @@ -49,6 +44,6 @@
}

.logo {
width: 141px;
width: 136px;
height: 40px;
}
12 changes: 10 additions & 2 deletions src/widgets/alumni/ui/alumni.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,25 @@ import { describe, expect, it } from 'vitest';
import { Alumni } from './alumni';

describe('Alumni', () => {
it('renders the title correctly', () => {
beforeEach(() => {
render(<Alumni />);
});

it('renders the title correctly', () => {
const titleElement = screen.getByText('Our alumni');

expect(titleElement).toBeInTheDocument();
});

it('renders the paragraph correctly', () => {
render(<Alumni />);
const paragraphElement = screen.getByText(/We are immensely proud of RS School alumni/i);

expect(paragraphElement).toBeInTheDocument();
});

it('renders all images for large screens', () => {
const imageElements = screen.getAllByRole('img');

expect(imageElements).toHaveLength(18);
});
});

0 comments on commit 82a1976

Please sign in to comment.