feat: allow symfony6, update tests for installable set #73

art-cg · 2022-01-06T11:11:29Z

Description of the change

Goal: Allow symfony 6
The rest of the changes are to run the tests (installable set)

This PR is based on https://github.com/rollbar/rollbar-php-symfony-bundle/pull/72/files thanks to @janicekt
I think we should allow symfony 6 first, and after that bump the php version. (should be discussed to which one in another issue). With this we can allow "rollbar/rollbar": "^2|^3" if possible.

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Maintenance
New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Fix [SC-]
Fix Improve documentation in README.md #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers assigned
Issue from task tracker has a link to this pull request
Changes have been reviewed by at least one other engineer

…ble set

composer.json

…ble set

…ble set, php for symfony 5 needs to be >=7.2.5

art-cg · 2022-01-06T15:23:49Z

This should be merged upfront #74

scorpioniz · 2022-01-25T13:45:09Z

Is there any progress? Would very appreciate for be able to upgrade to SF6... and now it's the only lib which is still not supported :(

danielmorell · 2022-03-23T01:29:48Z

Sorry for the long wait on this! I am going to take a look at this in the next day or two.

YaHkO · 2022-04-06T15:42:16Z

Hello @danielmorell any news ?

danielmorell · 2022-04-08T15:32:46Z

Dropping support for PHP 7.1 would be a breaking change and would require releasing a new major version. If we are going to release a major version it would probably make sense to make it PHP 8 only, and drop support for all of PHP 7. This is probably all the more true since Symphony 6 requires PHP 8. It would also allow us to take advantage of the new features of PHP 8.

Some community feedback on this would be helpful. What does everyone think about releasing a v5?

art-cg · 2022-04-11T10:53:54Z

@danielmorell In my point of view, this is not a BC Break because composer is handling this. Symfony itself is moveing from 8.0 to 8.1 in Symfony 6.1.

I like the Idea to go to PHP 8 and made some modernizations.
I upgraded the Code to PHP8 and make a lot of changes in the last commit.
It would be great to have some tests from real Applications.

danielmorell · 2022-04-12T14:20:46Z

I have created two new branches. next/4.x/main will hold the source for v4 and any minor/patch updates to that version. next/5.x/main. will hold all contributions to the future v5 release. Once it is ready for the official 5.0.0 release we will merge it into the master branch. We will try to make sure there are some beta releases so that people can test before the official 5.0.0 release.

We will also want to setup some CI tests to validate changes. I know #74 is adding that. I need to take a closer look at it. Thank you @art-cg for your many contributions!

It will take me a bit to look through this PR and grok all the updates. @art-cg if there is anything you think is not obvious, please drop a comment explaining it.

art-cg · 2022-04-12T14:46:13Z

@danielmorell Thanks for having a look.

I changed the base of the PR to the new Branch.

Changing the type in composer.json is not obvious.
https://symfony.com/doc/current/bundles/best_practices.html#installation

I removed some tests, that are not needed anymore with strong type hints. But this needs testing.
phpunit.xml was migrated with the integrated migration command.
@Package Notation and "useless" comments/docblocks are removed.
The ArrayShape Notation is specific to the IDE PhpStrom and helps to understand the code. Of course it is finde to revert that change. pleas let me know.
#[ArrayShape(['exception' => "array", 'frames' => "array"])]

I guess Tests/Fixtures/fatal.php can be removed. I am not sure why it is there. WDYT?
i would delete /var/.gitkeep as this folder is created on the fly by running tests. WDYT?
Readme.md could be improved and remove old projects. But that should be another PR.

I need to find a plugin/tool to check if Resources/doc/index.rst file could be parsed correct.

P.S. This Thursday is my last day at the actual company. So maybe i will send the other PR from another account.

danielmorell · 2022-04-28T09:26:45Z

Payload/Generator.php

@@ -51,19 +29,11 @@ public function getExceptionPayload($exception): array
            'body'             => [],
            'framework'        => Kernel::VERSION,
            'server'           => $this->getServerInfo(),
-            'language_version' => phpversion(),
+            'language_version' => PHP_VERSION,


AFAIK we don't send language versions via the API. I might be wrong but I am pretty sure this does not do anything. We might be able to completely remove it.

Author here. I can remove this if you wish. Any other comments on this PR to move things forward?

Thanks Chris, I am going to merge this with the base 5.x branch. If you would like you can submit a PR to that branch removing it.

art-cg added 2 commits January 6, 2022 12:03

feat: allow symfony6, update tests for installable set

bebbe60

feat: allow symfony6 and rollbar/rollbar 3, update tests for installa…

603950a

…ble set

art-cg mentioned this pull request Jan 6, 2022

Support PHP 8 #72

Closed

12 tasks

janicekt reviewed Jan 6, 2022

View reviewed changes

composer.json Outdated Show resolved Hide resolved

art-cg added 2 commits January 6, 2022 16:16

feat: allow symfony6 and rollbar/rollbar 3, update tests for installa…

78838da

…ble set

feat: allow symfony6 and rollbar/rollbar 3, update tests for installa…

cf41adc

…ble set, php for symfony 5 needs to be >=7.2.5

feat: drop support of php < 8

743dd45

This was referenced Apr 11, 2022

Symfony ^6.0 compatibility #76

Closed

test: add github actions #74

Merged

art-cg changed the base branch from master to next/5.x/main April 12, 2022 14:24

danielmorell reviewed Apr 28, 2022

View reviewed changes

danielmorell merged commit 1f70d61 into rollbar:next/5.x/main May 2, 2022

Chris53897 mentioned this pull request May 3, 2022

Feature/remove unused language version #77

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow symfony6, update tests for installable set #73

feat: allow symfony6, update tests for installable set #73

art-cg commented Jan 6, 2022

art-cg commented Jan 6, 2022

scorpioniz commented Jan 25, 2022

danielmorell commented Mar 23, 2022

YaHkO commented Apr 6, 2022

danielmorell commented Apr 8, 2022

art-cg commented Apr 11, 2022 •

edited

Loading

danielmorell commented Apr 12, 2022 •

edited

Loading

art-cg commented Apr 12, 2022

danielmorell Apr 28, 2022

Chris53897 Apr 30, 2022

danielmorell May 2, 2022

feat: allow symfony6, update tests for installable set #73

feat: allow symfony6, update tests for installable set #73

Conversation

art-cg commented Jan 6, 2022

Description of the change

Type of change

Related issues

Checklists

Development

Code review

art-cg commented Jan 6, 2022

scorpioniz commented Jan 25, 2022

danielmorell commented Mar 23, 2022

YaHkO commented Apr 6, 2022

danielmorell commented Apr 8, 2022

art-cg commented Apr 11, 2022 • edited Loading

danielmorell commented Apr 12, 2022 • edited Loading

art-cg commented Apr 12, 2022

danielmorell Apr 28, 2022

Choose a reason for hiding this comment

Chris53897 Apr 30, 2022

Choose a reason for hiding this comment

danielmorell May 2, 2022

Choose a reason for hiding this comment

art-cg commented Apr 11, 2022 •

edited

Loading

danielmorell commented Apr 12, 2022 •

edited

Loading