Support URI reserved characters in proxy server passwords. #757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was the guy who submitted the original PR for proxy server support in Rollbar. Unfortunately, that code will fail in the proxy requires authentication, the credentials include URI-reserved characters, such as '@' or '?', and the credentials are provided as part of the Rollbar configuration.
This PR addresses that by holding the proxy configuration information in a Struct instead of a URI object. This PR includes tests, but the fix has also been tested in a runtime environment.