Fix Rollbar::Util.deep_merge so it has default values for arguments #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the default value for the arguments in `Rollbar::Util.deep_merge` to be empty Hashes. Fixes #358
|
Can you add a test for the bug this fixes? |
added 2 commits
December 18, 2015 15:58
We want the default value for the arguments in `Rollbar::Util.deep_merge` to be empty Hashes. Fixes #358
Conflicts: lib/rollbar/util.rb
|
Sure, I pushed a test and a change in the implementation. I'll merge and release. |
jondeandres
added a commit
that referenced
this pull request
Dec 18, 2015
Fix Rollbar::Util.deep_merge so it has default values for arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the default value for the arguments in
Rollbar::Util.deep_mergeto be empty Hashes.Fixes #358