Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rollbar.js to 2.21.0 #1026

Closed
wants to merge 1 commit into from
Closed

Conversation

nertzy
Copy link

@nertzy nertzy commented Mar 1, 2021

Authored-by: Grant Hutchins grant@srpatx.com

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

(none)

Checklists

(none)

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Authored-by: Grant Hutchins <grant@srpatx.com>
@waltjones
Copy link
Contributor

@nertzy I think there are some dependency issues related to the recent Ruby 3.x release. To update your Rollbar.js without waiting for this to merge, in your config/initializers/rollbar.rb, add or update js_options

config.js_options = {
  rollbarJsUrl: "https://cdn.rollbar.com/rollbarjs/refs/tags/v2.21.0/rollbar.min.js"
}

The snippet will use the specified version.

@waltjones
Copy link
Contributor

For the build break, when this merges you should be able to rebase master to fix. #1027

@waltjones
Copy link
Contributor

#1045

@waltjones waltjones closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants