Skip to content

Commit

Permalink
[dotnet] Don't AOT compile resource assemblies. (xamarin#10418)
Browse files Browse the repository at this point in the history
Xamarin.iOS don't AOT compile resource assemblies, so we shouldn't do so in
.NET either (and in any case they end up causing native linking failures due
to duplicate native symbols).
  • Loading branch information
rolfbjarne authored Jan 14, 2021
1 parent db79cd6 commit 471da9f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,9 @@

<ItemGroup>
<_AssembliesToAOT Include="@(ResolvedFileToPublish)" Condition="'%(Extension)' == '.dll' Or '%(Extension)' == '.exe' " />
<!-- Exclude resource assemblies from AOT compilation -->
<_AssembliesToAOT Remove="@(ReferenceSatellitePaths)" /> <!-- this seems to be from referenced projects with satellite assemblies -->
<_AssembliesToAOT Remove="@(ResourceCopyLocalItems)" /> <!-- this seems to be from NuGets with satellite assemblies -->
</ItemGroup>
</Target>

Expand Down

0 comments on commit 471da9f

Please sign in to comment.