-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/documentation samples restructuring #32
Merged
georgejecook
merged 22 commits into
rokucommunity:master
from
blockscoped:bugfix/documentation_samples_restructuring
Mar 13, 2019
Merged
Bugfix/documentation samples restructuring #32
georgejecook
merged 22 commits into
rokucommunity:master
from
blockscoped:bugfix/documentation_samples_restructuring
Mar 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compiled version of `rooibos.cat.brs` with proper Roku comment syntax to avoid compile errors.
Remove the `rooibosDist.brs` file to avoid compile errors when running the nonEval sample code.
Add `rooibosFunctionMap.brs` to `nonEvalSample/source/tests` as this is referenced from `nonEvalSample/components/tests/NodeExampleTests.xml` and project won't compile without it.
…ch files are part of the framework and which are test specs.
…ontrol. Add .rooibosrc.json files for use with rooibosC preprocessor
…ple app and update the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n conjunction with a change to the rooibosC pre-processor this change introduces a more structured approach towards directory naming and hierarchy.
All rooibos related framework files/components are now under a
rooibos
directory, and all test specs are under aspecs
directory.This makes for a clear separation between framework files which in general shouldn't be edited, and user test specs which should.
User do not have to follow this exact naming convention as the RooibosC pre-processor is now more adaptable to different directory structures, but these conventions provide a good guide for structuring a codebase.