Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cwd option #158

Merged
merged 109 commits into from
Apr 16, 2024
Merged

Add cwd option #158

merged 109 commits into from
Apr 16, 2024

Conversation

MilapNaik
Copy link
Collaborator

@MilapNaik MilapNaik commented Apr 8, 2024 •
edited by TwitchBronBron
Loading

Implements #146

MilapNaik and others added 30 commits January 2, 2024 13:39
@MilapNaik
Make change to assume dest folder. Delete 2 old tests that looked for…
c6d2536 
… old behavior, add 2 more tests that look for new behavior
@MilapNaik
Sort files
2ba8eca
@MilapNaik @TwitchBronBron
Update src/RokuDeploy.ts
cc92e04 
Co-authored-by: Bronley Plumb <bronley@gmail.com>
@MilapNaik
Removed redundant entry.dest is null situation
9bbd579
@MilapNaik
Added a few commands, not all are working correctly
460cbf6
@MilapNaik
Merge branch 'v4' into add-cli-commands
de269ed 
# Conflicts:
#	src/RokuDeploy.ts
@MilapNaik
Merge branch 'fix-src-dest-handling' into add-cli-commands
7b9ee29
@MilapNaik
Move commands to their own file
6db962a
@MilapNaik
More command files
20eb21f
@MilapNaik
Change commands to help with tests
4e4b66a
@MilapNaik
Add testing suite for all cli (2 tests are not working)
2b809e6
@MilapNaik
Updated cli file after adding in commands and tests
13f2ca4
@MilapNaik
Fixed a few test cases
2d13441
@MilapNaik
Change name and input of table helper
09a275f
@TwitchBronBron
Totally broken code, but have the right names
e34ac97
@MilapNaik
Changed name of toTable
52b1bc0
@MilapNaik
Make test for objectToTable
f3a0c56
@MilapNaik
add yargs to pacjage.json
b5f41ca
@MilapNaik
add package-lock.json
4b95943
@MilapNaik
add new line at eof
b6c6223
@MilapNaik
Add test for coverage, also remove an unncessary '?'
f15f295
@MilapNaik
Merge branch 'add-cli-commands' into rename
08a587e 
# Conflicts:
#	src/util.ts
@TwitchBronBron
tweaks
6941e86
@TwitchBronBron
tweaks
ea49342
@TwitchBronBron
get from json stuff
616ff23
@MilapNaik
Merge branch 'v4' into rename
e2f3f80 
# Conflicts:
#	src/RokuDeploy.ts
#	src/cli.ts
#	src/commands/DeleteInstalledChannelCommand.ts
#	src/commands/GetDeviceInfoCommand.ts
#	src/commands/PrepublishCommand.ts
#	src/commands/PublishCommand.ts
#	src/commands/SignExistingPackageCommand.ts
#	src/commands/TakeScreenshotCommand.ts
#	src/commands/ZipPackageCommand.ts
#	src/index.ts
#	src/util.spec.ts
#	src/util.ts
@MilapNaik
Merge branch 'v4' into rename
190a2f1 
# Conflicts:
#	src/index.ts
@MilapNaik
Correct imports
cacf433
@MilapNaik
Last of the fsExtra changes
cbd6417
@MilapNaik
Create a load from json util, clean up cli.ts file with fleshing out …
ebab568 
…comments, delete unnecessary command/tests/options, partially fix exec command
MilapNaik added 20 commits March 26, 2024 14:56
@MilapNaik
Get rid of individual options checks
1b1bca3
@MilapNaik
Fixed option type in tests function
20eaeb7
@MilapNaik
Merge remote-tracking branch 'origin/throw-exceptions-on-missing-para…
0d09e4e 
…ms' into upgrade-typescript
@MilapNaik
Fixing eslint libraries to be compatible with the version of node we …
c27809c 
…are using
@MilapNaik
Fix lint errors: sorting unions and importing types in the same line …
75cff5b 
…as packages
@MilapNaik
Fix lint errors: lines around comments set to false, prefer nullish c…
b5b532b 
…oalescing set to false, propert results should be set as a class property, optional chaining, and no redundant types
@MilapNaik
Merge branch 'v4' into upgrade-typescript
928b32b 
# Conflicts:
#	src/RokuDeploy.spec.ts
@MilapNaik
Fix 2 more lint errors
1a8c5c5
@MilapNaik
Fix jszip error
83ee406
@MilapNaik
Undo last change
c41a97a
@MilapNaik
Turn off prefer optional chain
da43675
@MilapNaik
Disable duplicate imports error one time
896e0af
@MilapNaik
move eslint to a dev dependency
e529688
@MilapNaik
Fix eslint errors
a805021
@MilapNaik
Added npm install package lock, which actually fixed a different issue
1f914fa
@MilapNaik
add eslint plugin import, fix logical-assignment-operators error
cb25a04
@MilapNaik
Merge branch 'v4' into add-cwd-option
49198c9
@MilapNaik
Make screenshotDir use CWD
8b6a90e
@MilapNaik
Add cwd to command line and interfaces that use paths
97213f1
@MilapNaik
Add cwd tests
0cf777b
@MilapNaik MilapNaik requested a review from TwitchBronBron April 8, 2024 14:42
TwitchBronBron
TwitchBronBron approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you add those screenshotDir tests, this is good to go.

@TwitchBronBron TwitchBronBron merged commit d29e26f into v4 Apr 16, 2024
6 checks passed
@TwitchBronBron TwitchBronBron deleted the add-cwd-option branch April 16, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilapNaik @TwitchBronBron