Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
getHover
functionality into the plugin API so plugins can participate in providing hover support.Notable changes:
beforeProvideHover
,provideHover
,afterProvideHover
plugin events.event.hovers
collection.event.hovers
is empty.modify the plugin event pipleline to short-circuit if the handler returnsfalse
. This is useful foronGetHover
because only a single plugin may contribute a hover, so the first one that contributes needs to indicate they did so.BrsFile
getHover
functionality into theBscPlugin
. I didn't change the core logic, I just copied the code and made it work within the new object.