Better handling for createStringLiteral

src/astUtils/creators.spec.ts

@@ -0,0 +1,21 @@
+import { expect } from 'chai';
+import { createStringLiteral } from './creators';
+
+describe('creators', () => {
+
+    describe('createStringLiteral', () => {
+        it('wraps the value in quotes', () => {
+            expect(createStringLiteral('hello world').token.text).to.equal('"hello world"');
+        });
+        it('does not wrap already-quoted value in extra quotes', () => {
+            expect(createStringLiteral('"hello world"').token.text).to.equal('"hello world"');
+        });
+
+        it('does not wrap badly quoted value in additional quotes', () => {
+            //leading
+            expect(createStringLiteral('"hello world').token.text).to.equal('"hello world');
+            //trailing
+            expect(createStringLiteral('hello world"').token.text).to.equal('hello world"');
+        });
+    });
+});

src/astUtils/creators.ts

@@ -39,7 +39,16 @@ export function createDottedIdentifier(path: string[], range?: Range, namespaceN
     return new DottedGetExpression(obj, createToken(TokenKind.Identifier, ident, range), createToken(TokenKind.Dot, '.', range));
 }
 
+/**
+ * Create a StringLiteralExpression. The TokenKind.StringLiteral token value includes the leading and trailing doublequote during lexing.
+ * Since brightscript doesn't support strings with quotes in them, we can safely auto-detect and wrap the value in quotes in this function.
+ * @param value - the string value. (value will be wrapped in quotes if they are missing)
+ */
 export function createStringLiteral(value: string, range?: Range) {
+    //wrap the value in double quotes
+    if (!value.startsWith('"') && !value.endsWith('"')) {
+        value = '"' + value + '"';
+    }
     return new LiteralExpression(createToken(TokenKind.StringLiteral, value, range));
 }
 export function createIntegerLiteral(value: string, range?: Range) {