Try catch support #248
Merged
Try catch support #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Nov 20, 2020
| throw = true | ||
| end sub | ||
| `); | ||
|
|
||
| expect(parser.diagnostics[0]?.message).to.eql(DiagnosticMessages.cannotUseReservedWordAsIdentifier('throw').message); | ||
| expect(parser.diagnostics[0]?.message).to.eql(DiagnosticMessages.foundUnexpectedToken('=').message); |
There was a problem hiding this comment.
Checking for throw token earlier in the process causes a more generic error to be thrown. It's not really worth refactoring the parser just to get a slightly better error message, and we will definitely still get an error message so it's fine to just change this test.
TwitchBronBron
commented
Nov 20, 2020
| : print a.b.c : catch e : print "error" : end try | ||
| `); | ||
|
|
||
| // expectNoParseErrors(` |
There was a problem hiding this comment.
These three outlier syntaxes aren't currently supported. I want to support them eventually, but just don't have the time right now. I left them here so we don't forget to support them sometime in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for try/catch statements and
throwstatements.Resolves #218