Diagnostic diff #204
Merged
Diagnostic diff #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Oct 11, 2020
| @@ -57,7 +56,7 @@ export class StdlibArgument implements Argument { | |||
| } | |||
|
|
|||
| /** A fake location exists only within the BRS runtime. */ | |||
| static InternalRange = util.createRange(-1, -1, -1, -1); | |||
| static InternalRange = Range.create(-1, -1, -1, -1); | |||
There was a problem hiding this comment.
This was to work around a ts-node mocha testing circular reference issue that only showed up during local debugging of BrighterScript. Not related to the main purpose of the PR, but I needed to fix it so I figured I would include it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original diagnostic functionality would send the entire list of diagnostics, for every file, after every validate. For a project with a large number of diagnostics, this causes extremely poor performance anytime the diagnostic window is open, because the VSCode diagnostic window re-renders every diagnostic since the references have all changed (since we sent new copies of everything).
This PR fixes that problem by only sending messages for files whose diagnostics have changed. If a file's diagnostics haven't changed since the last time they were sent, that file is skipped. Files with added/changed/removed diagnostics are the only ones that will be updated.
VSCode handles diagnostics on a file-by-file basis, so by "skipping" a file when sending diagnostics, this causes that the file's previous diagnostics to persist.
Notable changes:
DiagnosticCollectionthat handles tracking the previous diagnostic landscape, and generates a diff of the current diagnostics compared to the previous one.