Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows more missing tokens in Transpile #1340

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

markwpearce
Copy link
Collaborator

For some expressions and statements, we can do a better job of assuming what some missing tokens will be.

This is useful for constructing AST nodes via code, so we don't need to specify tokens for open and close parens in a function call, for example.

Includes fixes for CallExpression, PrintStatement and FunctionExpression

Basically, anywhere there is a token where it HAS to be a certain character or string, we might as well put in a default for transpile time, so you don't need to include EVERY token in a constructor.

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@TwitchBronBron TwitchBronBron merged commit 2a6afd9 into release-1.0.0 Oct 30, 2024
4 checks passed
@TwitchBronBron TwitchBronBron deleted the allow_more_empty_tokens_in_transpile branch October 30, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants