Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CompletionItemKinds for typed variables #1145

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

markwpearce
Copy link
Collaborator

Fixes #1133

All variables that are Classes, Interfaces, Enum, functions, etc. will be displayed as variables.

@markwpearce markwpearce added this to the v1.0.0 milestone Apr 24, 2024
@@ -371,21 +371,32 @@ export class CompletionsProcessor {
private getCompletionKindFromSymbol(symbol: BscSymbol, areMembers = false) {
const type = symbol?.type;
const extraData = symbol?.data;
// eslint-disable-next-line no-bitwise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the bitwise?

@markwpearce markwpearce merged commit 9156eb1 into release-1.0.0 Apr 24, 2024
5 checks passed
@markwpearce markwpearce deleted the interface_completion_type branch April 24, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants