Support multi-scope diagnostics #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Apr 12, 2024
| } | ||
| } | ||
|
|
||
| private multiScopeCache = new Cache<string, BsDiagnosticWithOrigin>(); |
There was a problem hiding this comment.
We will need to clear this cache between each scope validation (similar to what we do in ScopeValidator)
markwpearce
added a commit
that referenced
this pull request
May 31, 2024
* Validate a file in a single scope context only * wip * Updated algorithm * Turned off duplicatesymboldiagnostics * Logic seems to be working * Remove commented out code * Try out validation without subscope namespace trees * Removed sub-scope namespace table caching in favor of full-scope requires vs provides checking * fixed windows path separators in tests * removed unused and commented out code * more commented out code removed * Sort scopes and files so they are processed more consistently. * Removed another commented out line of code * Removed program.lastValidationInfo, finds more resolutions in cross scope validation, and modifies scopeName sorting * removed file info generation validation metric * Fixed lint error * Added test * Solved issue of looking for relative namespace types * Fixes for m. and super() as unresolved symbols in classes * Support multi-scope diagnostics (#1135) Co-authored-by: Mark Pearce <markwpearce@gmail.com> * WIP * Uses a tree of provided nodes instead of a map * Using multi-scopes * all tests pass * fixed lint error * Fixes font type from docs * Fixed issue with union types in type expressions * fixes lint errors * Fixes #1164 * Checks non-aliased versions of required symbols when revalidating * Fix crash when transpiling an unknown namespace * Fix lint issue * Remove ClassType.superClass in favor of .parentType * Added breaking test * Cross Scope Validation also looks at members of interfaces/classes across all scopes * Also validate files that require a changed symbol * Only revalidate segments with changed symbol * Cache potential names of unresolved symbol * Make scope validation logging debug level * Really only validate segments that need it.. i think. * fixes issue of const defined from other reftypes * cahce components map for each validation cycle * Moved all name collision checking code to CrossScopeValidator * Handles invalid in union type member tables --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some diagnostics as multi-scope diagnostics so we don't clutter the diagnostics list with the same diagnostic over and over