Removes `CommentStatement` and all comment tokens from Lexer output #1083

markwpearce · 2024-03-03T03:30:46Z

Comments now reside SOLELY in leading trivia.
TranspileState.transpileToken() will automatically transpile comments (if they exist) ahead of the token
To still indent comments before a "block closing token" (eg. }, end sub, etc), use TranspileState.transpileEndBlockToken()`
Modified getSignatureHelp, getDocumentation, etc. to use leading trivia only

…bust

markwpearce · 2024-03-03T03:34:09Z

Addresses #1042
Addresses #1031

src/parser/Parser.ts

src/parser/SGTypes.ts

TwitchBronBron

Had a few suggestions, but overall looks good.

…hterscript into remove_comment_statement

markwpearce added 9 commits March 2, 2024 23:26

Do not include comment tokens in lexer output

981bd2a

Solved all broken tests in Parser

4f668be

Comments are missing from tranpilation. We need to add trailingTrivia

e43b218

Transpiles some occurences of trailing comments correctly

bd45060

just one failing transpile test

af8aee9

Completion processor tests pass

dd1983d

solved tests in astUtils and comment flag processor

c18eb9f

solved signiture help tests

79e7305

Fixed all the tests and made getting docs from leading tokens more ro…

f0808c9

…bust

markwpearce added this to the v1.0.0 milestone Mar 3, 2024

TwitchBronBron requested changes Mar 8, 2024

View reviewed changes

src/parser/Parser.ts Outdated Show resolved Hide resolved

src/parser/SGTypes.ts Outdated Show resolved Hide resolved

TwitchBronBron requested changes Mar 8, 2024

View reviewed changes

TwitchBronBron added 3 commits March 8, 2024 09:24

Merge branch 'release-1.0.0' of https://github.com/rokucommunity/brig…

719aba1

…hterscript into remove_comment_statement

Make the eofToken a getter

b42711f

Address PR comments

50a90fc

TwitchBronBron approved these changes Mar 8, 2024

View reviewed changes

TwitchBronBron merged commit 559ffd4 into rokucommunity:release-1.0.0 Mar 8, 2024
6 checks passed

Provide feedback