Completion on union type should only show shared properties #882
Milestone
Comments
TwitchBronBron
changed the title
TwitchBronBron
changed the title
TwitchBronBron
added a commit
that referenced
this issue
Sep 13, 2023
* Adds non-statement expressions to AST * WIP to verify namespace symbol table changes * Fix broken semantic tokens test * Solving more tests * Refactored Symbol Tables to keep track of teh defining AST node of a symbol * Completes refactor of completions to use symbol tables * Fixes namespace hovers * Cache data after loop in BuiltInInterfaceAdder * Comment documentaation gets a little formatting help - jsdoc tags are respected * Revert caching of symbol add calls in BuiltInInterfaceAdder * removed parser in body hack * fix for #881 * Use leadingTrivia for comments and fix #883 * Solves #882 --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
|
solved 69d3037 |
markwpearce
added a commit
that referenced
this issue
Sep 19, 2023
…) to Type System (#891) * Adds non-statement expressions to AST * WIP to verify namespace symbol table changes * Fix broken semantic tokens test * Solving more tests * Refactored Symbol Tables to keep track of teh defining AST node of a symbol * Completes refactor of completions to use symbol tables * Fixes namespace hovers * Cache data after loop in BuiltInInterfaceAdder * Comment documentaation gets a little formatting help - jsdoc tags are respected * Revert caching of symbol add calls in BuiltInInterfaceAdder * removed parser in body hack * fix for #881 * Use leadingTrivia for comments and fix #883 * Solves #882 * Brightscript Components, interfaces,Events and SceneGraph Nodes are in global SymbolTable * Fixed enum member issue * fixed build issue * Adds built in SceneGraph nodes and Custom components as types * Fixes some completions issues with custom components * Adds Custom Components to symbol tables * Some small fixes * added test and fixed build error * fix broken test * Removed mergedSymbolTable as sibling to scope.symbolTable * Renamed addDeferredComponentTypeSymbolCreation and generalized type chain seperators * Added comment for program.componentSymbolsToUpdate * Update timeout on long running test * Fixed typo --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Leveraging the v0.66 type system, I would expect the completions on a union type to show the shared properties from that union. In the below example, I should see "url" as the only completion option, not the fallback to all text in file.
The text was updated successfully, but these errors were encountered: