Fix indentation bug when brighterscript keywords are used as identifiers

[philanderson888]

Prevent brighterscript-specific keywords such as enum and class from triggering indentation when not contained within those actual ast node types.

class:

Fixes #77

[philanderson888]

pipeline failing on

not sure exactly what this means - if it is something to be concerned about or not. looks like a library issue, we can look at this later after we agree the fix in principle.

[TwitchBronBron]

pipeline failing on

not sure exactly what this means - if it is something to be concerned about or not. looks like a library issue, we can look at this later after we agree the fix in principle.

This issue is caused by the local install of brighterscript. Revert this change and then run npm install again in the brighterscript-formatter project, then commit your package.json and package-lock.json and it should resolve.

[philanderson888]

just rolled back all the commits to remove the package.json and package-lock.json files from the commits, then re-committed all the other changes.

just waiting to see if all the Github build tests pass now ...

[philanderson888]

seems to be failing on code coverage not quite 100%

at least it's not an error introduced by the changes per se, it's a code coverage error which we can deal with later ... will investigate later.

will tidy up code changes first.

[philanderson888]

code is tidy now

test is failing above because ... looks like ... code coverage is not 100%, not because of an error in the changes

I will have to look into writing fresh tests to cover extra code, to bring test coverage back up to 100%

[philanderson888]

OK @TwitchBronBron looks like

• code is working
• tests are passing

cc

@chrisdp @markwpearce @heart-of-code @addison-adler

[TwitchBronBron]

@philanderson888 I pushed a test that's failing and needs to be fixed. Can you take a look?

[philanderson888]

Hey

@chrisdp @markwpearce @heart-of-code @addison-adler

@TwitchBronBron added a Try ... Catch failing test as well into the mix, which I have fixed (I think!)

So code is ready for second round of code reviews, thanks all

here is output of bsfmt function after changes implemented

`
function doThis()
end function

function class()
end function

function try()
print "hello"
end function

function enum()
end function

function interface()
try
print "hello"
catch
end try
end function

function try()
print "hello"
try
print "hello"
catch e
print "hello"
end try
end function
`

[TwitchBronBron]

I tested this on a large internal project, and everything worked as expected. I think this is good to go! Nice work.

[philanderson888]

Thanks @TwitchBronBron appreciate that

Happy to help

cc @addison-adler let me know if this helps you, now that it's merged!