Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow spacing on dotted get paths #83

Conversation

philanderson888
Copy link
Contributor

@philanderson888 philanderson888 commented Jan 10, 2024

Remove spacing between dotted gets.

Here's an example:

format

@philanderson888
Copy link
Contributor Author

This is a continuation of previous merge request which was closed without realising a merge request was still open.

Totally recreated from scratch and original merge request replicated exactly line for line.

See previous trail at

#78 (comment)

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Sorry it took so long to review.

I tested against our huge internal project and encountered no incorrect formatting changes. Great work!

@TwitchBronBron TwitchBronBron merged commit 5091c70 into rokucommunity:master Jan 17, 2024
5 of 6 checks passed
@philanderson888
Copy link
Contributor Author

Thank you @TwitchBronBron

sounds great

I half caught a compliment there that it passed all the tests you threw ai it … happy to please and get it right :)

look forward to the next one which I’m ready for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants