-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TICKET 2] 🚀 update project to nextjs13 #5
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -48,7 +50,7 @@ | |||
"husky": "^7.0.2", | |||
"lint-staged": "^11.1.2", | |||
"prettier": "^2.4.1", | |||
"typescript": "^4.4.3" | |||
"typescript": "^5.0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
"@types/react-table": "^7.7.3", | ||
"@typescript-eslint/eslint-plugin": "^4.31.1", | ||
"@typescript-eslint/parser": "^4.31.1", | ||
"encoding": "^0.1.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do a follow up PR with more features 🤑
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Project has to be updated to NextJs 13
What is the new behavior?
_app.tsx
-document.tsx
and moved tolayout.tsx
.src/app/*
and prefix[route]/page.tsx
.chakra ui
,typescript
,nextjs
,@next/eslint-plugin-next
,react
andreact-dom
.api spacex land graphql
do not work.How can your PR break the app?
Super breaking changes
Other information
TODO:
[...nextauth].ts
must be fixed and tested properly.NextAuth
withGithub
need some secrets and ids to be implemented.Everything else is now working properly.
PD1:
NEXT_PUBLIC_URL
in Vercel is pointing to ->https://rickandmortyapi.com/graphql
PD2: Vercel project
node
version was updated to18.x
Screenshots (optional)