Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TICKET 2] 🚀 update project to nextjs13 #5

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

czhoffmann23
Copy link
Collaborator

@czhoffmann23 czhoffmann23 commented May 19, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Project has to be updated to NextJs 13

What is the new behavior?

  • Resolve package dependencies.
  • Restructure providers according to NextJs13 implementation.
  • Removed _app.tsx - document.tsx and moved to layout.tsx.
  • Restructure pages to work with src/app/* and prefix [route]/page.tsx.
  • Update Packages: chakra ui, typescript, nextjs, @next/eslint-plugin-next, react and react-dom.
  • Updates in API call, cause api api spacex land graphql do not work.
  • Add encoding package according to terminal warning/issue: GITHUB ISSUE.

How can your PR break the app?

Super breaking changes

Other information

TODO:

  • [...nextauth].ts must be fixed and tested properly.
  • NextAuth with Github need some secrets and ids to be implemented.

Everything else is now working properly.

PD1: NEXT_PUBLIC_URL in Vercel is pointing to -> https://rickandmortyapi.com/graphql
PD2: Vercel project node version was updated to 18.x

Screenshots (optional)

@czhoffmann23 czhoffmann23 added enhancement New feature or request help wanted Extra attention is needed labels May 19, 2023
@czhoffmann23 czhoffmann23 requested a review from bermann May 19, 2023 20:37
@czhoffmann23 czhoffmann23 self-assigned this May 19, 2023
@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 1:56pm

package.json Outdated Show resolved Hide resolved
@@ -48,7 +50,7 @@
"husky": "^7.0.2",
"lint-staged": "^11.1.2",
"prettier": "^2.4.1",
"typescript": "^4.4.3"
"typescript": "^5.0.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

"@types/react-table": "^7.7.3",
"@typescript-eslint/eslint-plugin": "^4.31.1",
"@typescript-eslint/parser": "^4.31.1",
"encoding": "^0.1.13",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary?

Copy link
Collaborator Author

@czhoffmann23 czhoffmann23 Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Yhozen Yhozen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do a follow up PR with more features 🤑

@czhoffmann23 czhoffmann23 merged commit 7983c67 into main Jun 2, 2023
@czhoffmann23 czhoffmann23 deleted the feature/update-nextjs13 branch June 2, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

Successfully merging this pull request may close these issues.

3 participants