Implementing review feedback. apache#4

rok · Jun 4, 2021 · f2f38ea · f2f38ea
1 parent c228eea
commit f2f38ea
Showing 1 changed file with 17 additions and 17 deletions.
diff --git a/cpp/src/arrow/compute/api_scalar.h b/cpp/src/arrow/compute/api_scalar.h
@@ -487,7 +487,7 @@ Result<Datum> IfElse(const Datum& cond, const Datum& left, const Datum& right,
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Year(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -499,7 +499,7 @@ Result<Datum> Year(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Month(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -510,7 +510,7 @@ Result<Datum> Month(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Day(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -522,7 +522,7 @@ Result<Datum> Day(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT Result<Datum> DayOfWeek(const Datum& values, ExecContext* ctx = NULLPTR);
 
@@ -533,7 +533,7 @@ ARROW_EXPORT Result<Datum> DayOfWeek(const Datum& values, ExecContext* ctx = NUL
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT Result<Datum> DayOfYear(const Datum& values, ExecContext* ctx = NULLPTR);
 
@@ -544,7 +544,7 @@ ARROW_EXPORT Result<Datum> DayOfYear(const Datum& values, ExecContext* ctx = NUL
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> ISOYear(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -557,18 +557,18 @@ Result<Datum> ISOYear(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT Result<Datum> ISOWeek(const Datum& values, ExecContext* ctx = NULLPTR);
 
-/// \brief ISOCalendar returns a (ISO year, ISO week, weekday) struct for each element of
+/// \brief ISOCalendar returns a (ISO year, ISO week, Day of week) struct for each element of
 /// `values`
 ///
 /// \param[in] values input to ISO calendar struct from
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT Result<Datum> ISOCalendar(const Datum& values, ExecContext* ctx = NULLPTR);
 
@@ -579,7 +579,7 @@ ARROW_EXPORT Result<Datum> ISOCalendar(const Datum& values, ExecContext* ctx = N
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT Result<Datum> Quarter(const Datum& values, ExecContext* ctx = NULLPTR);
 
@@ -589,7 +589,7 @@ ARROW_EXPORT Result<Datum> Quarter(const Datum& values, ExecContext* ctx = NULLP
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Hour(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -600,7 +600,7 @@ Result<Datum> Hour(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Minute(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -611,7 +611,7 @@ Result<Datum> Minute(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Second(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -622,7 +622,7 @@ Result<Datum> Second(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Millisecond(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -633,7 +633,7 @@ Result<Datum> Millisecond(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Microsecond(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -644,7 +644,7 @@ Result<Datum> Microsecond(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT
 Result<Datum> Nanosecond(const Datum& values, ExecContext* ctx = NULLPTR);
@@ -656,7 +656,7 @@ Result<Datum> Nanosecond(const Datum& values, ExecContext* ctx = NULLPTR);
 /// \param[in] ctx the function execution context, optional
 /// \return the resulting datum
 ///
-/// \since 4.0.0
+/// \since 5.0.0
 /// \note API not yet finalized
 ARROW_EXPORT Result<Datum> Subsecond(const Datum& values, ExecContext* ctx = NULLPTR);