Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New artifact emitting feature #96

Merged
merged 7 commits into from
May 17, 2022
Merged

New artifact emitting feature #96

merged 7 commits into from
May 17, 2022

Conversation

jonasbn
Copy link
Collaborator

@jonasbn jonasbn commented May 16, 2022

The action can now emit an optional artifact, which is a text file containing the output from pyspelling. This can be enabled and specified via the new workflow parameter: output_file

This closes #68

@jonasbn jonasbn added the enhancement New feature or request label May 16, 2022
@jonasbn jonasbn added this to the 0.24.0 milestone May 16, 2022
@jonasbn jonasbn self-assigned this May 16, 2022
Copy link
Contributor

@riccardoporreca riccardoporreca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See some suggestion / comment below, feel free to take / reject any of them.

There is a also missing documentation update in

output_file:
description: |
Indication that an artifact named `spellcheck-output.txt`
containing output from pyspelling should be generated
required: false

  output_file:
    description: |
      Name of a generated output file containing output from pyspelling.
    required: false

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
entrypoint.sh Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
jonasbn and others added 4 commits May 17, 2022 07:32
Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>
Co-authored-by: Riccardo Porreca <riccardo.porreca@mirai-solutions.com>
@jonasbn jonasbn merged commit 06e15ef into master May 17, 2022
@jonasbn jonasbn deleted the artifact branch May 17, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PySpelling output artifact?
2 participants