Merge pull request #48 from roihunter/fix-empty-default-category

GSTV-649 Don't call translateCategory when the idCategory is empty
roihunter · Sep 4, 2019 · 9b325bf · 9b325bf
2 parents e5823f3 + 01650c9
commit 9b325bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/classes/ProductJson.php b/classes/ProductJson.php
@@ -111,10 +111,10 @@ private function getSingleProduct($id_product, $id_lang)
 
     private function getProductDefaultCategory($idCategory, $idLanguage)
     {
-        if (!isset($this->categoryCache[$idCategory])) {
+        if ($idCategory && !isset($this->categoryCache[$idCategory])) {
             $this->categoryCache[$idCategory] = $this->translateCategory($idCategory, $idLanguage);
         }
-        return empty($this->categoryCache[$idCategory]) ? "" : $this->categoryCache[$idCategory];
+        return !$idCategory || empty($this->categoryCache[$idCategory]) ? "" : $this->categoryCache[$idCategory];
     }
 
     private function translateCategory($idCategory, $idLanguage)

diff --git a/roihunter.php b/roihunter.php
@@ -44,7 +44,7 @@ public function __construct()
     {
         $this->name = 'roihunter';
         $this->tab = 'advertising_marketing';
-        $this->version = '1.2.0';
+        $this->version = '1.2.1';
         $this->author = 'ROI Hunter';
         $this->need_instance = 1;
         $this->bootstrap = true;