Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No upper bound dependencies on AS/AP/Railties #235

Merged
merged 2 commits into from
Jan 12, 2018

Conversation

maschwenk
Copy link
Contributor

These upper bound dependencies make it so that every time I go to upgrade a Rails version, I need to point to a fork of Lograge until you guys release a new version. I don't see the major benefit of having an upper bound dependency. It just creates noise/busy work for you guys. If people have issues with later versions of Rails they will report them.

In my project of ~100 gems, Lograge and 2-3 others always come up when I go to do Rails upgrades for this reason. Last time around I helped pitch in (#208), but I think it doesn't make sense to keep doing it this way.

What do you guys think?

@benlovell benlovell merged commit 2ef2d9e into roidrage:master Jan 12, 2018
@benlovell
Copy link
Collaborator

Makes sense. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants