Config base_controller_class with string & constantize #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a severe problem where the controller response wasn't being returned. Something about placing the `ActionController::API` constant in the configuration block causes this.
|
@benlovell apologies about submitting a breaking feature before! This should handle it (confirmed in my app) This comes to mind: https://twitter.com/withzombies/status/829716565834752000?lang=en |
|
No trouble. I really ought to get around to adding proper integration tests in a hosting application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes #227 functional
This fixes a severe problem where the controller response wasn't being returned. Something about placing the
ActionController::APIconstant in the configuration block causes this.