Format only float values with decimals. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP status is not a float and thus should not get any decimas appended.
|
Thanks for the fix, no worries! |
roidrage
added a commit
that referenced
this pull request
Nov 13, 2012
Format only float values with decimals.
|
Can you cut a new release with this fix in it? |
|
@wuputah just pushed 0.1.1 to rubygems.org |
|
Thanks, much appreciated! |
tmcgilchrist
pushed a commit
to blake-education/lograge
that referenced
this pull request
Jan 10, 2013
Format only float values with decimals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meh, looks like I screwed up a bit, I'm sorry.
With the #19 Pull Request, the HTTP status code started to get formatted as a float, as I formatted any Numeric value with 2 decimals. Turns out, the status is not a float...
This pull request fixes the bug and slightly adapts the specs by adding the trailing whitespace to make sure to match the actual values and not just the beginning of them to catch this issue.
Again, I'm really sorry for that.