NameError: undefined method append_info_to_payload' for class ActionCable::Channel::Base'

[kntmrkm]

After upgraded 0.11.0.

Got a below error.

NameError: undefined method `append_info_to_payload' for class `ActionCable::Channel::Base'

with this setting

config.lograge.custom_payload do |controller|
        {
          user_agent: controller.request.user_agent,
        }
      end    

[decoch]

I am also facing the same issue.
Could I prevent error this but there is no problem?

# config/initializers/lograge.rb
config.lograge.base_controller_class = 'ActionController::Base'

[barrettclark]

I'm getting this error as well, but only when I run the asset precompile rake task in a Docker container. The application and rake tasks work fine locally. Weird.

Adding the initializer allows me to precompile assets in the container, but I had to tweak it a little to define the config:

# frozen_string_literal: true
Rails.application.config.lograge.base_controller_class = "ActionController::Base"

It seems to work fine. I am not using ActionCable in this app.

Thanks for the tip @decoch

[benlovell]

Sorry about this folks. I’m working on a fix.

[collimarco]

I have the same issue. Everything works fine on v0.10.0, while I get the error on v0.11.0. I am using the latest version of Rails (v5.2.3).

[xlts]

Sorry guys, that's my fault, I did overlook the custom_payload option when implementing Action Cable log formatting. Here's the PR with the fix: #286 (cc @benlovell)

As for the option itself, we should figure out the way custom_payload would work in Action Cable classes. Maybe it'd be good to support formatters for each event (perform_action, subscribe, unsubscribe ...) or for each class, as ActionCable::Connection::Base and ActionCable::Channel::Base don't share a common context.

[billdueber]

I still see this under 0.11.0 -- a quick look shows the code in the 0.11.0 tag doesn't have the fix from #286 in it (see

lograge/lib/lograge.rb

Lines 169 to 172 in 244ce40

	if base_classes.empty?
	base_classes << ActionController::Base
	base_classes << ActionCable::Channel::Base if defined?(ActionCable)
	end

). Are you planning a release that includes it?

[benlovell]

I've just released 0.11.1 including this fix.

[billdueber]

If what I referenced above is the problematic code, it's unchanged in 0.11.1 and I'm still getting the error.

[CHTJonas]

Likewise error is still occurring here 😢 This needs to be reopened @benlovell.

[benlovell]

Ugh. I’ll get this resolved properly tomorrow. Apologies folks.

[billdueber]

Hey, it's open source on a Friday afternoon. Don't apologize too hard 😄

[benbartling]

Just want to bring this one back up. Can we get #286 merged? Thanks for your work on this!

[xlts]

@benlovell please let us know if there's anything preventing #286 from being merged 🙂

[benlovell]

I'm not 100% convinced this resolves the issue. It has no test that verifies the behaviour so I have to set up a project myself to verify it manually and I'm reluctant to do this as something previously touted as a fix was not. If someone adds a spec for it I'll merge it right away. I've just not had the bandwidth to take care of it myself :(

[benlovell]

@xlts It works locally, if you could add a spec when you get a moment that would help. I'll cut a release with the fix now.