Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.6.1 Compresses Mobile View #287

Closed
shawnsull3 opened this issue Apr 17, 2023 · 3 comments · Fixed by #288
Closed

v1.6.1 Compresses Mobile View #287

shawnsull3 opened this issue Apr 17, 2023 · 3 comments · Fixed by #288
Labels
bug Something isn't working

Comments

@shawnsull3
Copy link

shawnsull3 commented Apr 17, 2023 •
edited
Loading

Using Docusaurus v2.4.0 and Redocusaurus v1.6.1 the mobile view is compressed. The bug only appears when built. Running the site locally with yarn start the mobile view is fine.

Screenshot of the mobile view and the CSS causing it:
image

It appears that the CSS that's causing the issue is overwriting the width: 100% from the index file.

This bug is affecting most of the sites found on the who's using Redocusaurus page as well as the Redocusaurus examples
image
image

Change log from v1.6.0 to v1.6.1: v1.6.0...v1.6.1

Reverting to Redocusaurus v1.6.0 fixes the issue.
@rohit-gohri rohit-gohri added the bug Something isn't working label Apr 17, 2023
@rohit-gohri
Copy link
Owner

Can confirm #276 introduced the regression. I'll revert it for now

@rohit-gohri rohit-gohri mentioned this issue Apr 17, 2023
Merged
rohit-gohri added a commit that referenced this issue Apr 17, 2023
@rohit-gohri
Revert "Fix to prevent rehydration of styles" (#288)
c0fcd04 
* Revert "Fix to prevent rehydration of styles (#276)"

Fixes #287 

This reverts commit 42bb731.
@rohit-gohri
Copy link
Owner

Thanks for reporting, release 1.6.2 is out now

@shawnsull3
Copy link
Author

@rohit-gohri No problem - thanks for the fix!

I tried looking into why the changes in 1.6.1 were causing this regression but I couldn't quite figure it out.

@hugocaillard hugocaillard mentioned this issue May 10, 2023
Merged
@andrewdmaclean andrewdmaclean mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Fix to prevent rehydration of styles" rohit-gohri/redocusaurus
2 participants
@rohit-gohri @shawnsull3