Fixes fabric8io#1177 Minor changes to ImageTrigger generation

Added fabric8.openshift.setImageTriggerAutomatic flag which would
be able to enable/disable automatic deployments.

CHANGELOG.md

@@ -14,6 +14,8 @@ After this we will switch probably to real [Semantic Versioning 2.0.0](http://se
 * Fix 1130: Added flag fabric8.openshift.trimImageInContainerSpec which would set the container image reference to "", this is done to handle weird 
   behavior of Openshift 3.7 in which subsequent rollouts lead to ImagePullErr.
 * Feature 1174: ImageStreams use local lookup policy by default to simplify usage of Deployment or StatefulSet resources on Openshift
+* Fix 1177: Added flag fabric8.openshift.setImageTriggerAutomatic which would be able to enable/disable automatic deployments whenever there is new image
+  generated.
 
 ###3.5.34
 * Feature 1003: Added suspend option to remote debugging 

doc/src/main/asciidoc/inc/goals/build/_fabric8-resource.adoc

@@ -185,4 +185,8 @@ Resource goal also validates the generated resource descriptors using API specif
 | *fabric8.openshift.trimImageInContainerSpec*
 | If value is set to `true` then it would set the container image reference to "", this is done to handle weird behavior of Openshift 3.7 in which subsequent rollouts lead to ImagePullErr
 | false
-|===
+
+| *fabric8.openshift.setImageTriggerAutomatic*
+| If the value is set to `false` then automatic deployments would be disabled.
+| true
+|===

plugin/src/main/java/io/fabric8/maven/plugin/converter/DeploymentConfigOpenShiftConverter.java

@@ -49,7 +49,7 @@ public DeploymentConfigOpenShiftConverter(Long openshiftDeployTimeoutSeconds) {
     }
 
     @Override
-    public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec) {
+    public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec, boolean setImageTriggerAutomatic) {
         if (item instanceof DeploymentConfig) {
             DeploymentConfig resource = (DeploymentConfig) item;
 

plugin/src/main/java/io/fabric8/maven/plugin/converter/DeploymentOpenShiftConverter.java

@@ -50,7 +50,7 @@ public DeploymentOpenShiftConverter(PlatformMode mode, Long openshiftDeployTimeo
     }
 
     @Override
-    public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec) {
+    public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec, boolean setImageTriggerAutomatic) {
             Deployment resource = (Deployment) item;
             DeploymentConfigBuilder builder = new DeploymentConfigBuilder();
             builder.withMetadata(resource.getMetadata());
@@ -119,10 +119,11 @@ public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec) {
                             specBuilder.addNewTrigger()
                                     .withType("ImageChange")
                                     .withNewImageChangeParams()
-                                    .withAutomatic(true)
+                                    .withAutomatic(setImageTriggerAutomatic)
                                     .withNewFrom()
                                     .withKind("ImageStreamTag")
                                     .withName(image.getSimpleName() + ":" + tag)
+                                    .withNamespace(image.getUser())
                                     .endFrom()
                                     .withContainerNames(containerName)
                                     .endImageChangeParams()

plugin/src/main/java/io/fabric8/maven/plugin/converter/KubernetesToOpenShiftConverter.java

@@ -24,6 +24,6 @@
  */
 public interface KubernetesToOpenShiftConverter {
 
-    HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec);
+    HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec, boolean setImageTriggerAutomatic);
 
 }

plugin/src/main/java/io/fabric8/maven/plugin/converter/NamespaceOpenShiftConverter.java

@@ -24,7 +24,7 @@
  */
 public class NamespaceOpenShiftConverter implements KubernetesToOpenShiftConverter {
     @Override
-    public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec) {
+    public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec, boolean setImageTriggerAutomatic) {
         return new ProjectRequestBuilder().withMetadata(item.getMetadata()).build();
     }
 }

plugin/src/main/java/io/fabric8/maven/plugin/converter/ReplicSetOpenShiftConverter.java

@@ -32,7 +32,7 @@
  */
 public class ReplicSetOpenShiftConverter implements KubernetesToOpenShiftConverter {
     @Override
-    public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec) {
+    public HasMetadata convert(HasMetadata item, boolean trimImageInContainerSpec, boolean setImageTriggerAutomatic) {
         ReplicaSet resource = (ReplicaSet) item;
         ReplicationControllerBuilder builder = new ReplicationControllerBuilder();
         builder.withMetadata(resource.getMetadata());

plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java

@@ -256,6 +256,9 @@ public class ResourceMojo extends AbstractResourceMojo {
     @Parameter(property = "fabric8.openshift.trimImageInContainerSpec", defaultValue = "false")
     private Boolean trimImageInContainerSpec;
 
+    @Parameter(property = "fabric8.openshift.setImageTriggerAutomatic", defaultValue = "true")
+    private Boolean setImageTriggerAutomatic;
+
     @Parameter(property = "kompose.dir", defaultValue = "${user.home}/.kompose/bin")
     private File komposeBinDir;
 
@@ -757,7 +760,7 @@ private HasMetadata convertKubernetesItemToOpenShift(HasMetadata item) {
         }
 
         KubernetesToOpenShiftConverter converter = openShiftConverters.get(item.getKind());
-        return converter != null ? converter.convert(item, trimImageInContainerSpec) : item;
+        return converter != null ? converter.convert(item, trimImageInContainerSpec, setImageTriggerAutomatic) : item;
     }
 
     // ==================================================================================