-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration with URIParser #22
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
30b7f93
Add integration with URIParser
davidanthoff 039e09d
Merge branch 'master' into uri
davidanthoff 1fc20e7
Escape during URI conversion
davidanthoff 8bcc284
Merge branch 'master' into uri
davidanthoff 42e895f
Properly import URIParser
davidanthoff aaaa843
Format white spaces away
davidanthoff e679a49
Throw proper exception type
davidanthoff 2dbb655
Add two URI tests
davidanthoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
julia 0.6 | ||
Compat 0.17.0 | ||
URIParser | ||
FilePathsBase 0.1.0 | ||
Reexport 0.1.0 | ||
Reexport 0.1.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
function URIParser.URI(p::AbstractPath) | ||
if isempty(root(p)) | ||
error("$p is not an absolute path") | ||
end | ||
|
||
b = IOBuffer() | ||
print(b, "file://") | ||
|
||
if !isempty(drive(p)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably test the drive behaviour. |
||
print(b, "/") | ||
print(b, drive(p)) | ||
end | ||
|
||
for i=2:length(p.parts) | ||
print(b, "/") | ||
print(b, URIParser.escape(p.parts[i])) | ||
end | ||
|
||
return URIParser.URI(String(take!(b))) | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,6 @@ using Base.Test | |
|
||
@testset "FilePaths" begin | ||
|
||
include("test_uri.jl") | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
using URIParser | ||
using FilePaths | ||
|
||
@testset "URI" begin | ||
@test string(URI(p"/foo/bar")) == "file:///foo/bar" | ||
@test string(URI(p"/foo foo/bar")) == "file:///foo%20foo/bar" | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to throw an
ArgumentError
here and we should test that error condition.