Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): improve filters and docs #210

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Conversation

rodrigo-brito
Copy link
Owner

  • Refactor SQL storage filter
  • Improve code docs

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 48.96% // Head: 48.80% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (a04432a) compared to base (9d6ff17).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   48.96%   48.80%   -0.17%     
==========================================
  Files          19       19              
  Lines        2510     2502       -8     
==========================================
- Hits         1229     1221       -8     
  Misses       1209     1209              
  Partials       72       72              
Impacted Files Coverage Δ
storage/sql.go 71.42% <100.00%> (-4.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rodrigo-brito rodrigo-brito merged commit 0dcd438 into main Oct 16, 2022
@rodrigo-brito rodrigo-brito deleted the refactor-storage branch October 16, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants