Select parameter tokens based on preceeding code token

Gemfile

@@ -31,10 +31,15 @@ group :test do
 end
 
 group :development do
-  # For Changelog generation
   if RUBY_VERSION > '1.9'
-    gem 'github_changelog_generator',                                 :require => false if RUBY_VERSION >= '2.2.2'
-    gem 'github_changelog_generator', '~> 1.13.0',                    :require => false if RUBY_VERSION < '2.2.2'
-    gem 'rack', '~> 1.0',                                             :require => false if RUBY_VERSION < '2.2.2'
+    # For Changelog generation
+    if RUBY_VERSION >= '2.2.2'
+      gem 'github_changelog_generator', :require => false
+    else
+      gem 'github_changelog_generator', '~> 1.13.0', :require => false
+      gem 'rack', '~> 1.0', :require => false
+    end
+
+    gem 'pry'
   end
 end

lib/puppet-lint/plugins/check_classes/parameter_order.rb

@@ -22,6 +22,7 @@ def check
         end
 
         next unless hash_or_array_stack.empty? && paren_stack.empty?
+        next unless parameter?(token)
         next unless required_parameter?(token)
 
         prev_tokens = class_idx[:param_tokens][0..i]
@@ -38,9 +39,19 @@ def check
     end
   end
 
-  def required_parameter?(token)
+  def parameter?(token)
     return false unless token.type == :VARIABLE
+    return false unless token.prev_code_token
+
+    [
+      :LPAREN, # First parameter, no type specification
+      :COMMA,  # Subsequent parameter, no type specification
+      :TYPE,   # Parameter with simple type specification
+      :RBRACK, # Parameter with complex type specification
+    ].include?(token.prev_code_token.type)
+  end
 
+  def required_parameter?(token)
     data_type = token.prev_token_of(:TYPE, :skip_blocks => true)
     return false if data_type && data_type.value == 'Optional'
 

spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb

@@ -147,5 +147,23 @@
 
       it { expect(problems).to have(0).problems }
     end
+
+    context "#{type} parameter with array operation" do
+      let(:code) do
+        <<-END
+          #{type} ntp (
+            # XXX: remove self from list
+            Array[String] $ntp_servers = [
+              'foo',
+              'bar',
+              'baz',
+            ] - $::fqdn,
+            Array[String] $pools       = [],
+          ) { }
+        END
+      end
+
+      it { expect(problems).to have(0).problems }
+    end
   end
 end