Fix ensure_first_param fix method to retrieve the full value of the ensure parameter #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the fix method for the
ensure_first_paramcheck looked for the first:COMMAor:SEMICtoken after the ensure param name to find the end of the parameter value, which works for most cases, but not when the value of the ensure parameter is a selector.This PR fixes this behaviour by adding a
next_token_ofmethod toPuppetLint::Lexer::Tokenthat encapsulates the logic of finding the next token of a certain type (and optionally value) with smarts to skip over blocks. Similarly, aprev_token_ofmethod also now exists. These two methods resolve #660 and we can later refactor a lot of the puppet-lint codebase to use these methods and simplify the code a lot.Fixes #659 & #660