Remove 1.8 references. #647
Conversation
|
|
||
| if RUBY_VERSION > '1.8' | ||
| # requires ruby 1.9+, on 1.8 we'll fall back to the old regex parsing | ||
| gem 'rspec-json_expectations', '~> 1.4' |
There was a problem hiding this comment.
This block should always be present, rather than removed.
There was a problem hiding this comment.
You're correct. I missed that. Why did this not break during the unit tests?
There was a problem hiding this comment.
Because @binford2k was nice enough to politely skip that when the module doesn't load with a Rescue statement.
There was a problem hiding this comment.
Oh, maybe that should go away as well.
| end | ||
|
|
||
| group :development do | ||
| # For Changelog generation | ||
| if RUBY_VERSION > '1.9' |
There was a problem hiding this comment.
Does > 1.9 cover 1.9.3 or only 2.0.0+?
There was a problem hiding this comment.
I does cover 1.9.3. It was to prevent 1.8. I'll double check from build logs.
|
I'd like @binford2k to take a quick look and see if there's anywhere else the json_expectations would need adjustment. |
No description provided.