Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable code_on_top_scope by default until the noise can be reduced (… #590

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

rnelson0
Copy link
Collaborator

#580)

@binford2k
Copy link
Collaborator

I dunno about this. It seems like throwing the baby out with the bathwater.

I can see the argument, though I'd wager that linting the site manifest is not a common usage, in comparison to linting modules. What if we accepted another command line argument, say --manifest or --site, that could enable/disable a set of tests to make it more appropriate for testing the site manifest.

For future enhancement, I'd like to add test groups that could do this in a more generic way.

@rnelson0
Copy link
Collaborator Author

It probably is throwing the baby out with the bathwater, in a way - however, it's not an existing check in a published gem version yet, so disabling it by default only means that users have to enable it if they want to use it.

Long term, group flags of some sort would definitely be helpful.

@binford2k binford2k merged commit 3e0b62f into master Dec 21, 2016
@rnelson0 rnelson0 deleted the disable_code_on_top_scope branch December 22, 2016 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants