Plugin review; disable unnecessary plugins

[rnelson0]

This is a breaking change, scheduled for v3.0.0.

[binford2k]

Could you attach a quick list of the rationale for each plugin being disabled?

[binford2k]

did you mean 'disable_names_containing_dash'

[rnelson0]

Fixing

[rnelson0]

Rationale from #561
All plugins are on by default. Over time, the lint plugins have drifted from the style guide. We reviewed all the core checks and correlated them to the style guide. The checks below either cannot be correlated, require a style guide addition/modification, or are not part of linting. I have commented them for disabling, removing, or requiring a style guide update.

check_classes.rb

• names_containing_dash Remove, handled by puppet parser validate
• code_on_top_scope Style Guide Update, no matching style guide reference but known good practice

check_documentation.rb

• documentation Style Guide Update, https://docs.puppet.com/guides/style_guide.html#public-and-private needs improvement in the recommendation

check_nodes.rb

• unquoted_node_name Style Guide Update, no matching style guide reference but known good practice

check_resources.rb

• duplicate_params Remove, handled by puppet parser validate

check_strings.rb

• only_variable_string Disable, style guide reference in discussion in DOCUMENT-274
• quoted_booleans Style Guide Update, no matching style guide reference but known good practice
• puppet_url_without_modules Disable, no style guide reference

check_variables.rb

• variable_contains_dash Remove, handled by puppet parser validate
• variable_is_lowercase Remove, handled by puppet parser validate