[561] Provide style guide references for each check #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnelson0
force-pushed
the
plugin_style_guide_links
branch
from
7bec586 to
ad8979c
Compare
rnelson0
force-pushed
the
plugin_style_guide_links
branch
from
ad8979c to
217e7c3
Compare
rodjek
reviewed
Oct 27, 2016
| @@ -146,6 +158,7 @@ def check | |||
| elsif token.type == :RBRACE || token.type == :SEMIC | |||
| level_tokens[indent_depth_idx].each do |arrow_tok| | |||
| unless arrow_tok.column == indent_depth[indent_depth_idx] || level_tokens[indent_depth_idx].size == 1 | |||
| puts indent_depth | |||
There was a problem hiding this comment.
Looks like some debugging puts calls got committed?
| @@ -168,6 +181,7 @@ def check | |||
|
|
|||
| def fix(problem) | |||
| new_ws_len = (problem[:indent_depth] - (problem[:newline_indent].length + problem[:token].prev_code_token.to_manifest.length + 1)) | |||
| puts "#{new_ws_len}, #{problem[:indent_depth]}, #{problem[:newline_indent].length}, #{problem[:token].prev_code_token.to_manifest.length + 1}, #{problem[:token].inspect}" | |||
rnelson0
force-pushed
the
plugin_style_guide_links
branch
from
217e7c3 to
42d8728
Compare
|
@rodjek Good catch, thanks! Not at all sure what mistake I made there, maybe time to rm/clone again, as one does :) |
|
The style guide is also numbered, so you could say section 12.1 or whatever. I like the links though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.