(GH416) Wrong arrow alignment when key has interpolated variable #497
Conversation
|
Fixes #416, needs review. |
|
@ahpook @binford2k @kylog This is ready for review now. In #416, two users confirmed no adverse side effects with this branch on their code, in addition to the spec tests working (I'm not sure why the |
| @@ -362,7 +362,7 @@ def interpolate_string(string, line, column) | |||
| lexer.tokens.each do |token| | |||
| tok_col = column + token.column + (ss.pos - contents.size - 1) | |||
| tok_line = token.line + line - 1 | |||
| tokens << new_token(token.type, token.value, token.value.size, :line => tok_line, :column => tok_col) | |||
| tokens << new_token(token.type, token.value, token.value.size + 3, :line => tok_line, :column => tok_col) | |||
There was a problem hiding this comment.
What does this do on a line w/o the curlies? e.g., "A double quoted $string without properly bracketed variables"
There was a problem hiding this comment.
Ugh, it does not work properly. However I think #492 will give us a better grasp on the issue to debug it.
There was a problem hiding this comment.
So we are still waiting to merge this one, correct?
Ensure that interpolated variable delimiters (`${}`) are not ignored when calculating alignment.
The `--fix` function remains broken, see #424 for progress on that front.
|
Yep, still waiting. Im going to close it until it's ready. |
Ensure that interpolated variable delimiters (
${}) are not ignored when calculating alignment.The
--fixfunction remains broken, see #424 for progress on that front.