Support for multiple node names in unquoted_node_name #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
pushed a commit
that referenced
this pull request
Sep 22, 2014
Support for multiple node names in unquoted_node_name
|
Thanks for the fix, there's another problem now though. It only finds, and fixes, the first defined node in the file... node1 {
stuff
}
node2 {
stuff
}In the above example puppet-lint complains about 'node1' not 'node2', and if run with --fix it will fix 'node1' but not 'node2', and it will not complain about it in subsequent runs either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Puppet DSL supports multiple node names in a single block as a comma separated list however the first iteration of this check only checked the first value. This PR fixes that to find all unquoted node names in the node block.
Closes #323