Rejig tests #238
Merged
Rejig tests #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the kind of janky have_problem and only_have_problem matchers with the new contain_(warning,error,fixed) matcher. This greatly improves the readability of both the tests and their output on failure.
This annoyed me when I was fixing the specs, so I’m going to change it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have_problemandonly_have_problemmatchers in favour of a newcontain_{warning,error,fixed}matcher. This matcher greatly improves the readability of the specs and improves the output of the tests on failure.expectsyntaxdefine defined inside a classmessage todefined type defined inside a class, because it annoyed me.