Handle variables with array & hash references #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a seperate logic block would handle enclosed variables and anything else would be passed to a new instance of the lexer for tokenisation. Unfortunately, this lead to variables that had array or hash references being classified as :NAME tokens and then when running with fix mode enabled, would not be turned back into variables.
Adjusted the logic in this check so that it allows for any number of array or hash references at the end of a variable name, while still correctly detecting that it is only a single variable.
rodjek
pushed a commit
that referenced
this pull request
Aug 3, 2013
Handle variables with array & hash references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two issues that were brought up in #181
$foo[0]) as variables, so when run with fix mode enabled, the leading$would be strippedonly_variable_stringswould throw a false negative result for these sorts of variables.